[v8-dev] Re: Use Unique in HConstant and remove UniqueValueId. (issue 24350014)

Tue, 24 Sep 2013 02:18:03 -0700

lgtm with nits

https://codereview.chromium.org/24350014/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/24350014/diff/1/src/hydrogen-instructions.h#newcode3468
src/hydrogen-instructions.h:3468: // If this is a numerical constant,
object_ either points to to the
points to to the -> points to the

https://codereview.chromium.org/24350014/diff/1/src/unique.h
File src/unique.h (left):

https://codereview.chromium.org/24350014/diff/1/src/unique.h#oldcode115
src/unique.h:115: // WARNING: Only do this if you have access to the
heap.
Any reason you removed this comment?

https://codereview.chromium.org/24350014/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to