On 2013/09/24 09:17:54, Toon Verwaest wrote:
lgtm with nits
https://codereview.chromium.org/24350014/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/24350014/diff/1/src/hydrogen-instructions.h#newcode3468
src/hydrogen-instructions.h:3468: // If this is a numerical constant,
object_
either points to to the
points to to the -> points to the
Done.
https://codereview.chromium.org/24350014/diff/1/src/unique.h
File src/unique.h (left):
https://codereview.chromium.org/24350014/diff/1/src/unique.h#oldcode115
src/unique.h:115: // WARNING: Only do this if you have access to the heap.
Any reason you removed this comment?
Because it turns out that we often get the handle out to pass it somewhere
else,
without dereferencing it. That's safe. The unsafe part would be the
dereference
of that handle (where the normal rules of handle dereferencing apply), or
trying
to make another Unique in a different uniqueness scope (where the checks in
the
constructor apply).
https://codereview.chromium.org/24350014/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
