https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc#newcode2587
src/arm/lithium-codegen-arm.cc:2587: void
LCodeGen::DoStringCompareAndBranch(LStringCompareAndBranch* instr) {
On 2013/09/26 10:06:33, ulan wrote:
ASSERT(ToRegister(instr->context()).is(cp));
Done.
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc#newcode2902
src/arm/lithium-codegen-arm.cc:2902: void LCodeGen::DoCmpT(LCmpT* instr)
{
On 2013/09/26 10:06:33, ulan wrote:
ASSERT(ToRegister(instr->context()).is(cp));
Done.
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc#newcode3996
src/arm/lithium-codegen-arm.cc:3996:
ASSERT(ToDoubleRegister(instr->result()).is(d2));
On 2013/09/26 10:06:33, ulan wrote:
Set cp as in other DoMath* functions.
Done.
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc#newcode4565
src/arm/lithium-codegen-arm.cc:4565: void
LCodeGen::DoStringAdd(LStringAdd* instr) {
On 2013/09/26 10:06:33, ulan wrote:
ASSERT(ToRegister(instr->context()).is(cp));
Done.
https://codereview.chromium.org/24596002/diff/1/src/arm/lithium-codegen-arm.cc#newcode5726
src/arm/lithium-codegen-arm.cc:5726:
ASSERT(instr->hydrogen()->is_backwards_branch());
On 2013/09/26 10:06:33, ulan wrote:
Indentation is off.
Done.
https://codereview.chromium.org/24596002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
