LGTM
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-arm.cc#newcode1214
src/arm/lithium-arm.cc:1214: : UseFixed(instr->context(), cp);
I think we can use UseAny here because the context is used in deferred
code.
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/24596002/diff/11001/src/arm/lithium-codegen-arm.cc#newcode3683
src/arm/lithium-codegen-arm.cc:3683:
ASSERT(ToRegister(instr->context()).is(cp));
I think we don't need context in cp here since it is loaded in call to
runtime from deferred.
https://codereview.chromium.org/24596002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
