Please take another look. This is a bigger re-write that moves all the logic
into Hydrogen and unifies a bunch of unreachable code handling with deopt
block
handling.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h#newcode3393
src/hydrogen-instructions.h:3393: bool SameConstantObject(HConstant*
other) {
On 2013/08/16 15:02:20, Michael Starzinger wrote:
nit: Let's rename this to just "SameConstant", it doesn't look
specific to
objects.
Actually, I use DataEquals now. Makes it even simpler.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen-instructions.h#newcode3394
src/hydrogen-instructions.h:3394: if (HasSmiValue() &&
other->HasSmiValue()) {
On 2013/08/16 15:02:20, Michael Starzinger wrote:
Shouldn't this be HasInteger32Value in these checks? Also what about
HasDoubleValue?
See above.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen.cc#newcode8028
src/hydrogen.cc:8028: return !right->IsConstant() ||
On 2013/08/16 15:02:20, Michael Starzinger wrote:
nit: Should fit into one line.
Done.
https://codereview.chromium.org/22876009/diff/13001/src/hydrogen.cc#newcode8032
src/hydrogen.cc:8032: return !left->IsConstant() ||
On 2013/08/16 15:02:20, Michael Starzinger wrote:
nit: Should fit into one line.
Done.
https://codereview.chromium.org/22876009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
