LGTM with comments.
https://codereview.chromium.org/22876009/diff/71027/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/22876009/diff/71027/src/arm/lithium-arm.cc#newcode872
src/arm/lithium-arm.cc:872: new(zone())
LDummyUse(UseAny(current->OperandAt(1)));
OperandAt(i)
https://codereview.chromium.org/22876009/diff/71027/src/hydrogen-mark-unreachable.cc
File src/hydrogen-mark-unreachable.cc (right):
https://codereview.chromium.org/22876009/diff/71027/src/hydrogen-mark-unreachable.cc#newcode43
src/hydrogen-mark-unreachable.cc:43: if (block->IsReachable()) {
nit: you can avoid one level of indentation by turning this into an
early return:
if (block->IsUnreachable()) continue;
https://codereview.chromium.org/22876009/diff/71027/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/22876009/diff/71027/src/hydrogen.cc#newcode3635
src/hydrogen.cc:3635: // If the current test block is deoptimizing due
to an unhandle clause
nit: unhandled
https://codereview.chromium.org/22876009/diff/71027/src/hydrogen.cc#newcode3636
src/hydrogen.cc:3636: // of the switch, the test instruction is in the
next block since (the
nit: no ()
https://codereview.chromium.org/22876009/diff/71027/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/22876009/diff/71027/src/ia32/lithium-ia32.cc#newcode916
src/ia32/lithium-ia32.cc:916: ? graph()->GetConstant1() :
nit: please put the ':' in the next line, under the '?'. Or move the
next line up here, right behind the ':'.
https://codereview.chromium.org/22876009/diff/71027/src/ia32/lithium-ia32.cc#newcode921
src/ia32/lithium-ia32.cc:921: new(zone())
LDummyUse(UseAny(current->OperandAt(1)));
bug: OperandAt(i)!
https://codereview.chromium.org/22876009/diff/71027/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/22876009/diff/71027/src/x64/lithium-x64.cc#newcode872
src/x64/lithium-x64.cc:872: new(zone())
LDummyUse(UseAny(current->OperandAt(1)));
OperandAt(i)!
https://codereview.chromium.org/22876009/diff/71027/test/mjsunit/constant-branch-folding-liveness.js
File test/mjsunit/constant-branch-folding-liveness.js (right):
https://codereview.chromium.org/22876009/diff/71027/test/mjsunit/constant-branch-folding-liveness.js#newcode1
test/mjsunit/constant-branch-folding-liveness.js:1: // Copyright 2013
the V8 project authors. All rights reserved.
You can drop this file; it is already present as
test/mjsunit/regress/regress-crbug-280333.js.
https://codereview.chromium.org/22876009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
