Already looking good...
https://codereview.chromium.org/23477061/diff/25002/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/23477061/diff/25002/src/heap.h#newcode1889
src/heap.h:1889:
What about?
- Making weak_object_to_code, weak_object_to_code_address, and
set_weak_object_to_code private?
- Adding an InitializeWeakObjectToCodeTable which calls
set_weak_object_to_code(isolate_->heap()->undefined_value()).
- Creating the WeakHashtable when accessing the non-initialized hash
table.
https://codereview.chromium.org/23477061/diff/25002/src/heap.h#newcode2388
src/heap.h:2388: Object* weak_object_to_code_;
Can we move that up to the other weak list heads, after
allocation_sites_list_? Moreover, the comment about the initialization
applies also to the other weak lists, we could add it on top of the list
heads. Aaand, can we change the name to weak_object_to_code_table_.
https://codereview.chromium.org/23477061/diff/25002/src/incremental-marking.cc
File src/incremental-marking.cc (right):
https://codereview.chromium.org/23477061/diff/25002/src/incremental-marking.cc#newcode651
src/incremental-marking.cc:651:
IncrementalMarkingMarkingVisitor::MarkObjectWithoutPush(
Why don't you call MarkWeakObjectToCode here?
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.cc#newcode433
src/mark-compact.cc:433: if
(heap()->weak_embedded_maps_verification_enabled()) {
This property should be renamed to
weak_embedded_objects_verification_enabled
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.cc#newcode2158
src/mark-compact.cc:2158: void
MarkCompactCollector::MarkWeakObjectToCode(RootMarkingVisitor* visitor)
{
Visitor is not needed for this function.
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.h
File src/mark-compact.h (right):
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.h#newcode845
src/mark-compact.h:845: // Mark the global table from weak objects to
dependent code without
Mark the global table which maps weak objects to dependent...
https://codereview.chromium.org/23477061/diff/25002/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (left):
https://codereview.chromium.org/23477061/diff/25002/src/x64/lithium-codegen-x64.cc#oldcode92
src/x64/lithium-codegen-x64.cc:92: if
(FLAG_weak_embedded_maps_in_optimized_code) {
Why did you remove that flag?
https://codereview.chromium.org/23477061/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
