LGTM, a few renaming/reformatting nits
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/23477061/diff/25002/src/mark-compact.cc#newcode433
src/mark-compact.cc:433: if
(heap()->weak_embedded_maps_verification_enabled()) {
On 2013/10/01 14:50:29, ulan wrote:
On 2013/10/01 13:13:50, Hannes Payer wrote:
> This property should be renamed to
weak_embedded_objects_verification_enabled
Can we instead rename the method to
VerifyWeakEmbeddedMapsAndObjectsInOptimizedCode()?
Renaming of the property triggers renaming of
NoWeakEmbeddedMapsVerificationScope, which makes many lines longer
than 80. :)
I think object is general enough to also reflect maps.
What about renaming the method to
VerifyWeakEmbeddedObjectsInOptimizedCode()?
The scope and the field should not be called *Map* anymore, we need a
shorter name for that. Anything that is generic enough is fine with me.
https://codereview.chromium.org/23477061/diff/41001/src/handles.h
File src/handles.h (right):
https://codereview.chromium.org/23477061/diff/41001/src/handles.h#newcode324
src/handles.h:324:
remove one newline
https://codereview.chromium.org/23477061/diff/41001/src/handles.h#newcode328
src/handles.h:328:
remove one newline
https://codereview.chromium.org/23477061/diff/41001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/23477061/diff/41001/src/heap.h#newcode1313
src/heap.h:1313:
remove one newline
https://codereview.chromium.org/23477061/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
