2 comments, otherwise LGTM.
https://codereview.chromium.org/25696004/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/25696004/diff/1/src/x64/lithium-codegen-x64.cc#newcode2791
src/x64/lithium-codegen-x64.cc:2791: MemOperand operand =
MemOperand(ToRegister(instr->object()), offset);
How about a helper function that does the right move based on
representation and sign-extend like:
void LCodeGen::EmitAppropriateMove(Register result,
MemOperand operand,
Representation representation,
bool sign_extend);
All four of these locations could benefit from that.
https://codereview.chromium.org/25696004/diff/1/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):
https://codereview.chromium.org/25696004/diff/1/src/x64/lithium-x64.cc#newcode2061
src/x64/lithium-x64.cc:2061:
!instr->access().representation().IsSpecialization() &&
Could you add a comment to summarize this decision?
https://codereview.chromium.org/25696004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
