Just one real comment. Otherwise looking good.
https://codereview.chromium.org/26827002/diff/1/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/26827002/diff/1/src/code-stubs.h#newcode676
src/code-stubs.h:676: FastCloneShallowObjectStub(AllocationSiteMode
allocation_site_mode,
As discussed offline: I don't think it makes much sense to keep the
allocation_site as part of the minor key because it's value is
statically chosen. I don't (yet) see a use-case where we need more that
one stub per length. Let's drop that and decide whether to tack
allocations when we compile the stub.
https://codereview.chromium.org/26827002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/26827002/diff/1/src/hydrogen.cc#newcode4341
src/hydrogen.cc:4341: Handle<Object> boilerplate;
nit: The type of "boilerplate" should be Handle<JSObject>.
https://codereview.chromium.org/26827002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
