LGTM with a few minor nits.
https://codereview.chromium.org/26827002/diff/6001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/26827002/diff/6001/src/code-stubs.h#newcode694
src/code-stubs.h:694: STATIC_ASSERT(kMaximumClonedProperties < 16);
nit: Assert is obsolete now.
https://codereview.chromium.org/26827002/diff/6001/src/code-stubs.h#newcode697
src/code-stubs.h:697: int NotMissMinorKey() {
nit: Unnecessary white-space change, still fits into one line.
https://codereview.chromium.org/26827002/diff/6001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/26827002/diff/6001/src/hydrogen.cc#newcode4344
src/hydrogen.cc:4344: ASSERT(literals_cell->IsAllocationSite());
nit: Assert is not needed, the cast below will do one for you.
https://codereview.chromium.org/26827002/diff/6001/src/hydrogen.cc#newcode4351
src/hydrogen.cc:4351: IsFastLiteral(boilerplate,
nit: Second predicate should fit into one line now.
https://codereview.chromium.org/26827002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
