Revision: 17143
Author: [email protected]
Date: Thu Oct 10 13:32:00 2013 UTC
Log: Fixing tagged binary operation input type feedback.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/26710002
http://code.google.com/p/v8/source/detail?r=17143
Modified:
/branches/bleeding_edge/src/code-stubs.cc
=======================================
--- /branches/bleeding_edge/src/code-stubs.cc Thu Oct 10 08:45:40 2013 UTC
+++ /branches/bleeding_edge/src/code-stubs.cc Thu Oct 10 13:32:00 2013 UTC
@@ -569,14 +569,12 @@
State max_input = Max(left_state_, right_state_);
- // Avoid unnecessary Representation changes.
+ // TODO(olivf) Instead of doing this normalization we should have a
Hydrogen
+ // version of the LookupNumberStringCache to avoid a converting
StringAddStub.
if (left_state_ == STRING && right_state_ < STRING) {
right_state_ = GENERIC;
} else if (right_state_ == STRING && left_state_ < STRING) {
left_state_ = GENERIC;
- } else if ((right_state_ == GENERIC && left_state_ != STRING) ||
- (left_state_ == GENERIC && right_state_ != STRING)) {
- left_state_ = right_state_ = GENERIC;
} else if (!has_int_result() && op_ != Token::SHR &&
max_input <= NUMBER && max_input > result_state_) {
result_state_ = max_input;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
