LGTM, but please update per comments about delay slots.
You should probably run a subset of tests again, just to be sure, at least
the
new test test/mjsunit/bitwise-operations-bools.js
https://codereview.chromium.org/26742006/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/26742006/diff/1/src/mips/lithium-codegen-mips.cc#newcode4911
src/mips/lithium-codegen-mips.cc:4911: __ Branch(&done);
We should probably use the delay slot here (and 2 more place below) to
save an instruction.
__ Branch(USE_DELAY_SLOT, &done);
__ mov(input_reg, zero_reg); // In delay slot.
https://codereview.chromium.org/26742006/diff/1/src/mips/lithium-codegen-mips.cc#newcode4916
src/mips/lithium-codegen-mips.cc:4916: __ li(input_reg, Operand(1));
li() of 1 is always single instruction, use delay slot here also.
https://codereview.chromium.org/26742006/diff/1/src/mips/lithium-codegen-mips.cc#newcode4923
src/mips/lithium-codegen-mips.cc:4923: __ Branch(&done);
Use delay slot.
https://codereview.chromium.org/26742006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
