LGTM, with a comment-only nit. Go ahead and fix on the dcommit push if you
want.
https://codereview.chromium.org/26742006/diff/12001/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/26742006/diff/12001/src/mips/lithium-codegen-mips.cc#newcode4911
src/mips/lithium-codegen-mips.cc:4911: __ mov(input_reg, zero_reg);
nit: I really do like to see comment "// In delay slot." when there is
room to put it there. Just an extra reminder when we are reading the
code. 3 places.
https://codereview.chromium.org/26742006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
