Revision: 17255
Author: [email protected]
Date: Thu Oct 17 13:09:28 2013 UTC
Log: Make it possible to run a test only in the standard variant.
Use this for mjsunit/unicode-case-overoptimization, which is not
related to Crankshaft at all and takes ages.
[email protected]
Review URL: https://codereview.chromium.org/27704002
http://code.google.com/p/v8/source/detail?r=17255
Modified:
/branches/bleeding_edge/test/benchmarks/testcfg.py
/branches/bleeding_edge/test/mjsunit/mjsunit.status
/branches/bleeding_edge/test/preparser/testcfg.py
/branches/bleeding_edge/tools/run-tests.py
/branches/bleeding_edge/tools/testrunner/local/statusfile.py
/branches/bleeding_edge/tools/testrunner/local/testsuite.py
=======================================
--- /branches/bleeding_edge/test/benchmarks/testcfg.py Mon Aug 5 14:54:09
2013 UTC
+++ /branches/bleeding_edge/test/benchmarks/testcfg.py Thu Oct 17 13:09:28
2013 UTC
@@ -172,7 +172,7 @@
os.chdir(old_cwd)
- def VariantFlags(self):
+ def VariantFlags(self, testcase, default_flags):
# Both --nocrankshaft and --stressopt are very slow.
return [[]]
=======================================
--- /branches/bleeding_edge/test/mjsunit/mjsunit.status Wed Oct 2 13:30:31
2013 UTC
+++ /branches/bleeding_edge/test/mjsunit/mjsunit.status Thu Oct 17 13:09:28
2013 UTC
@@ -66,7 +66,7 @@
'array-constructor': [PASS, TIMEOUT],
# Very slow on ARM and MIPS, contains no architecture dependent code.
- 'unicode-case-overoptimization': [PASS, ['arch == arm or arch ==
android_arm or arch == mipsel', TIMEOUT]],
+ 'unicode-case-overoptimization': [PASS, NO_VARIANTS, ['arch == arm or
arch == android_arm or arch == mipsel', TIMEOUT]],
##############################################################################
# This test expects to reach a certain recursion depth, which may not
work
=======================================
--- /branches/bleeding_edge/test/preparser/testcfg.py Fri Oct 4 16:21:23
2013 UTC
+++ /branches/bleeding_edge/test/preparser/testcfg.py Thu Oct 17 13:09:28
2013 UTC
@@ -112,7 +112,7 @@
with open(testcase.flags[0]) as f:
return f.read()
- def VariantFlags(self):
+ def VariantFlags(self, testcase, default_flags):
return [[]];
=======================================
--- /branches/bleeding_edge/tools/run-tests.py Fri Sep 20 13:13:57 2013 UTC
+++ /branches/bleeding_edge/tools/run-tests.py Thu Oct 17 13:09:28 2013 UTC
@@ -332,8 +332,9 @@
if options.cat:
verbose.PrintTestSource(s.tests)
continue
- variant_flags = s.VariantFlags() or VARIANT_FLAGS
- s.tests = [ t.CopyAddingFlags(v) for t in s.tests for v in
variant_flags ]
+ s.tests = [ t.CopyAddingFlags(v)
+ for t in s.tests
+ for v in s.VariantFlags(t, VARIANT_FLAGS) ]
s.tests = ShardTests(s.tests, options.shard_count, options.shard_run)
num_tests += len(s.tests)
for t in s.tests:
=======================================
--- /branches/bleeding_edge/tools/testrunner/local/statusfile.py Wed Sep 25
12:37:00 2013 UTC
+++ /branches/bleeding_edge/tools/testrunner/local/statusfile.py Thu Oct 17
13:09:28 2013 UTC
@@ -35,6 +35,7 @@
CRASH = "CRASH"
SLOW = "SLOW"
FLAKY = "FLAKY"
+NO_VARIANTS = "NO_VARIANTS"
# These are just for the status files and are mapped below in DEFS:
FAIL_OK = "FAIL_OK"
PASS_OR_FAIL = "PASS_OR_FAIL"
@@ -43,7 +44,7 @@
KEYWORDS = {}
for key in [SKIP, FAIL, PASS, OKAY, TIMEOUT, CRASH, SLOW, FLAKY, FAIL_OK,
- PASS_OR_FAIL, ALWAYS]:
+ NO_VARIANTS, PASS_OR_FAIL, ALWAYS]:
KEYWORDS[key] = key
DEFS = {FAIL_OK: [FAIL, OKAY],
@@ -60,6 +61,10 @@
return SKIP in outcomes or SLOW in outcomes
+def OnlyStandardVariant(outcomes):
+ return NO_VARIANTS in outcomes
+
+
def IsFlaky(outcomes):
return FLAKY in outcomes
=======================================
--- /branches/bleeding_edge/tools/testrunner/local/testsuite.py Tue Aug 6
14:39:39 2013 UTC
+++ /branches/bleeding_edge/tools/testrunner/local/testsuite.py Thu Oct 17
13:09:28 2013 UTC
@@ -74,8 +74,10 @@
def ListTests(self, context):
raise NotImplementedError
- def VariantFlags(self):
- return None
+ def VariantFlags(self, testcase, default_flags):
+ if testcase.outcomes and
statusfile.OnlyStandardVariant(testcase.outcomes):
+ return [[]]
+ return default_flags
def DownloadData(self):
pass
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
