LGTM with nits.
https://codereview.chromium.org/28793002/diff/60001/src/harmony-math.js
File src/harmony-math.js (right):
https://codereview.chromium.org/28793002/diff/60001/src/harmony-math.js#newcode42
src/harmony-math.js:42: if (!IS_NUMBER(x)) x = NonNumberToNumber(x);
Replace with TO_NUMBER_INLINE
https://codereview.chromium.org/28793002/diff/60001/test/mjsunit/harmony/math-trunc.js
File test/mjsunit/harmony/math-trunc.js (right):
https://codereview.chromium.org/28793002/diff/60001/test/mjsunit/harmony/math-trunc.js#newcode31
test/mjsunit/harmony/math-trunc.js:31: assertEquals("-Infinity",
String(1/Math.trunc(-0)));
Get -0 in some "cleverer" way here, otherwise it might be optimized "at
parse time".
https://codereview.chromium.org/28793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
