https://codereview.chromium.org/29203003/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/29203003/diff/1/src/flag-definitions.h#newcode510
src/flag-definitions.h:510: "print statistics of the maxiumum memory
committed by the heap GC "
On 2013/10/22 14:46:07, Hannes Payer wrote:
"by the heap GC" => "for the heap"
Done.
https://codereview.chromium.org/29203003/diff/1/src/flag-definitions.h#newcode510
src/flag-definitions.h:510: "print statistics of the maxiumum memory
committed by the heap GC "
On 2013/10/22 14:46:07, Hannes Payer wrote:
maximum
Done.
https://codereview.chromium.org/29203003/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/29203003/diff/1/src/spaces.cc#newcode1127
src/spaces.cc:1127: heap()->UpdateMaximumCommitted();
On 2013/10/22 14:46:07, Hannes Payer wrote:
Instead of calling heap()->UpdateMaximumCommitted() on every update to
a given
space, why don't we call it at the end of a GC? I guess it would make
sense to
find a single place in the code.
The heap size can be increased when there is no GC happening. If we
only did this at GC time we would miss the potential maximum overall
heap size wouldn't we?
https://codereview.chromium.org/29203003/diff/1/src/spaces.cc#newcode1554
src/spaces.cc:1554: }
On 2013/10/22 14:46:07, Hannes Payer wrote:
Instead of duplicating this code, why don't we add as SetCapacity
method that
takes care of the the maximum as well.
Done.
https://codereview.chromium.org/29203003/diff/1/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/29203003/diff/1/src/spaces.h#newcode2384
src/spaces.h:2384: from_space_.MaximumCommittedMemory());
On 2013/10/22 11:44:10, Benedikt Meurer wrote:
Nit: indentation
Done.
https://codereview.chromium.org/29203003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
