https://codereview.chromium.org/29203003/diff/1/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/29203003/diff/1/src/spaces.cc#newcode1127
src/spaces.cc:1127: heap()->UpdateMaximumCommitted();
On 2013/10/24 08:12:35, Hannes Payer wrote:
On 2013/10/23 14:40:23, rmcilroy wrote:
> On 2013/10/22 14:46:07, Hannes Payer wrote:
> > Instead of calling heap()->UpdateMaximumCommitted() on every
update to a
given
> > space, why don't we call it at the end of a GC? I guess it would
make sense
to
> > find a single place in the code.
>
> The heap size can be increased when there is no GC happening.  If we
only did
> this at GC time we would miss the potential maximum overall heap
size wouldn't
> we?

Beginning of GC is what I meant, that should be fine, right?

Done.

https://codereview.chromium.org/29203003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to