Hi Danno, I've addressed these issues. PTAL. It might be possible/desirable
to
break up the CL a bit.
https://codereview.chromium.org/35413006/diff/30001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/35413006/diff/30001/src/heap.cc#newcode470
src/heap.cc:470: void Heap::ClearAllKeyedStoreICs() {
On 2013/10/23 12:22:11, danno wrote:
Can you please add a parameter of the IC type and just make this
"ClearAllICsByKind" or something of that effect?
Done.
https://codereview.chromium.org/35413006/diff/30001/src/heap.cc#newcode475
src/heap.cc:475: code->ClearInlineCaches(Code::KEYED_STORE_IC);
On 2013/10/23 12:22:11, danno wrote:
You don't have to do this if the code is not a normal FUNCTION or
OPTIMIZED (I
think), so you might be able to save walking RelocInfos for those by
testing the
code type before clearing the caches.
Done.
https://codereview.chromium.org/35413006/diff/30001/src/ia32/ic-ia32.cc
File src/ia32/ic-ia32.cc (right):
https://codereview.chromium.org/35413006/diff/30001/src/ia32/ic-ia32.cc#newcode714
src/ia32/ic-ia32.cc:714: static void
HasElementCallbacksInPrototypeChain(
On 2013/10/23 12:22:11, danno wrote:
This (and similar code in other implementations) belongs in the
platform-specific macro assembler.
Done.
https://codereview.chromium.org/35413006/diff/30001/src/ia32/ic-ia32.cc#newcode742
src/ia32/ic-ia32.cc:742: static void KeyedStoreGenerateGenericHelper(
On 2013/10/23 12:22:11, danno wrote:
I wish *so* badly that we generaed this in Hydrogen. It would make
this hackery
unnecessary.
I've added this to the TODO list.
https://codereview.chromium.org/35413006/diff/30001/src/ia32/ic-ia32.cc#newcode779
src/ia32/ic-ia32.cc:779:
On 2013/10/23 12:22:11, danno wrote:
nit: please remove the extraneous whitespace change
Done.
https://codereview.chromium.org/35413006/diff/30001/src/ia32/ic-ia32.cc#newcode847
src/ia32/ic-ia32.cc:847:
On 2013/10/23 12:22:11, danno wrote:
nit: please remove the extraneous whitespace change
Done.
https://codereview.chromium.org/35413006/diff/30001/src/ia32/ic-ia32.cc#newcode860
src/ia32/ic-ia32.cc:860:
On 2013/10/23 12:22:11, danno wrote:
nit: please remove the extraneous whitespace change
Done.
https://codereview.chromium.org/35413006/diff/30001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/35413006/diff/30001/src/ic.cc#newcode1966
src/ic.cc:1966: receiver->MayHaveIndexedCallbacksInPrototypeChain()) {
On 2013/10/23 12:22:11, danno wrote:
Why doesn't MayHaveIndexedCallbacksInPrototypeChain also check
receiver->map()->has_element_callbacks()? It seems the first is just a
generalization of the second.
Done.
https://codereview.chromium.org/35413006/diff/30001/src/ic.cc#newcode1966
src/ic.cc:1966: receiver->MayHaveIndexedCallbacksInPrototypeChain()) {
On 2013/10/23 12:22:11, danno wrote:
I think you can and should combine this with the
IsMapInArrayPrototypeChain case
above into a separate function that computes and returns use_ic.
Done.
https://codereview.chromium.org/35413006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
