thx, addressed Michael's points.
https://codereview.chromium.org/35413006/diff/450001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/35413006/diff/450001/src/heap.h#newcode770
src/heap.h:770: void ClearAllICsByKind(Code::Kind kind);
On 2013/11/04 15:18:17, Michael Starzinger wrote:
nit: Let's add a short one-liner comment that states that this
iterates the
whole code-space.
Done.
https://codereview.chromium.org/35413006/diff/450001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/35413006/diff/450001/src/x64/macro-assembler-x64.cc#newcode4993
src/x64/macro-assembler-x64.cc:4993: movq(elements, FieldOperand(object,
JSObject::kElementsOffset));
On 2013/11/04 15:18:17, Michael Starzinger wrote:
Instead of specializing the semantics of this function to use the
elements
register, let's just pass an arbitrary "scratch" register and let the
caller
take care of saving and restoring it. AFAICT "rdi" should still be
available as
a true scratch register at both call-sites.
Thx, done.
https://codereview.chromium.org/35413006/diff/450001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):
https://codereview.chromium.org/35413006/diff/450001/src/x64/macro-assembler-x64.h#newcode1416
src/x64/macro-assembler-x64.h:1416: void
HasDictionaryInPrototypeChain(Register object, Register elements,
On 2013/11/04 15:18:17, Michael Starzinger wrote:
nit: Let's name this "JumpIfDictionaryInPrototypeChain", that name
better
implies what the method does.
Good idea. Done.
https://codereview.chromium.org/35413006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
