I do not agree with this change yet:
- We are introducing a new flag to the StackTraceFrameIterator and all its
parent classes just to disable an assert.
- Do we actually understand why the stackframe iterator cannot work when
being
called from a builtin (I assume that you are referring to C++ builtins in
like
ArrayShift)? I was under the assumption that the StackFrameIterator should
be
able to handle all types of frames on the stack.
https://codereview.chromium.org/43693002/diff/200001/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/43693002/diff/200001/src/x64/macro-assembler-x64.cc#newcode4097
src/x64/macro-assembler-x64.cc:4097: addq(rsp, Immediate(2 *
kPointerSize));
Use Drop(2) instead.
https://codereview.chromium.org/43693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
