https://codereview.chromium.org/43693002/diff/200001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/43693002/diff/200001/src/x64/code-stubs-x64.cc#newcode5835
src/x64/code-stubs-x64.cc:5835: __ movq(arg_reg_1, isolate,
RelocInfo::EXTERNAL_REFERENCE);
On 2013/10/30 15:12:57, Yang wrote:
If you need to erect a frame and also pass the isolate, why don't you
simply
call into a runtime function using CallRuntime? That uses the
CEntryStub and
takes care of the isolate.
There are two reasons for this:
1. CallRuntime doesn't preserve registers. Since we call HeapProfiler in
the middle of allocation we should be careful not to change current
state of the instrumented code.
2. Does a lot of checks related to GC which are unnecessary in our case
since the allocation hook is guaranteed not to do any heap allocations.
As long as we'd like to minimize perf impact of the allocation tracker
we'd rather avoid unnecessary checks.
https://codereview.chromium.org/43693002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
