https://codereview.chromium.org/48913008/diff/100001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/48913008/diff/100001/src/objects.cc#newcode15764
src/objects.cc:15764: new_table->set(table->EntryToIndex(entry), *key);
On 2013/11/04 10:58:06, rafaelw wrote:
One question, this probably doesn't matter, but it seemed strange to
me that the
original code was:

table->set(EntryToIndex(entry), key);

seems like it should be

table->set(table->EntryToIndex(entry), key);

or here,

new_table->set(new_table->EntryToIndex(entry), *key);

Hmm, HashTable::EntryToIndex() should be a static function. It shouldn't
need a receiver object.

https://codereview.chromium.org/48913008/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to