Ok. Ready for review. PTAL.
https://codereview.chromium.org/48913008/diff/100001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/48913008/diff/100001/src/objects.h#newcode4068
src/objects.h:4068: static Handle<ObjectHashSet> EnsureSetCapacity(
Note that I've named this "EnsureSetCapacity" because I can't figure out
how to get the C++ compiler to stop complaining because in the
CALL_HEAP_FUNCTION implementation, it seems to be trying to invoke the
static method (forgetting about the inherted templatized method from
HashTable.
I'm hoping you know what the solution to this is. Same problem below
with ShrinkSet.
https://codereview.chromium.org/48913008/diff/100001/test/cctest/test-dictionary.cc
File test/cctest/test-dictionary.cc (right):
https://codereview.chromium.org/48913008/diff/100001/test/cctest/test-dictionary.cc#newcode178
test/cctest/test-dictionary.cc:178: int gc_count =
isolate->heap()->gc_count();
I just took a guess at how to address this test.
https://codereview.chromium.org/48913008/diff/100001/test/cctest/test-dictionary.cc#newcode182
test/cctest/test-dictionary.cc:182: // Calling Remove() should not cause
GC ever.
This comment doesn't seem true. I believe it's always true for this
test, but Remove() can clearly allocate more memory via Shrink.
https://codereview.chromium.org/48913008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
