Hi Danno, looks good. I have some nits, when those are addressed then...
lgtm.
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc#newcode1323
src/code-stubs-hydrogen.cc:1323: current_probe + 1);
The recursive call is interesting here, but the base case is clear:
current_probe == kNumberDictionaryProbes, then deopt if that point is
reached. nice!
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc#newcode1357
src/code-stubs-hydrogen.cc:1357: details_compare.End();
nit: I would engage in the { } indentation style here like BinaryOpStub
and FastNewClosureStub because it would be easier to parse the control
flow.
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc#newcode1370
src/code-stubs-hydrogen.cc:1370: USE(stub);
What are the USE statements for, can they be removed?
https://codereview.chromium.org/19492007/diff/160001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/19492007/diff/160001/src/hydrogen.cc#newcode1918
src/hydrogen.cc:1918: HValue*
HGraphBuilder::BuildElementIndexHash(HValue* index) {
Could you update the comment in macro-assembler-X.cc where it sez:
// Compute the hash code from the untagged key. This must be kept in
sync
// with ComputeIntegerHash in utils.h.
Add this location as another place to be kept in sync.
https://codereview.chromium.org/19492007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
