LGTM with a few more nits.
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc#newcode1270
src/code-stubs-hydrogen.cc:1270: explicit CodeStubGraphBuilder(Isolate*
isolate,
nit: no "explicit" necessary
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc#newcode1289
src/code-stubs-hydrogen.cc:1289: HValue*
CodeStubGraphBuilder<KeyedLoadDictionaryElementStub>::
nit: I'd break after "HValue*" instead of after "::", but I leave that
up to you.
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc#newcode1302
src/code-stubs-hydrogen.cc:1302: ? hash
nit: 4 space indent
https://codereview.chromium.org/19492007/diff/160001/src/code-stubs-hydrogen.cc#newcode1326
src/code-stubs-hydrogen.cc:1326: result =
graph()->GetConstantUndefined();
As discussed, the automatic environment padding handles this, but I'd
weakly prefer Push()ing some value (undefined, 0, take your pick)
explicitly.
https://codereview.chromium.org/19492007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
