Reviewers: Sven Panne,
Message:
Adding back assert now that issue is fixed in Chrome. PTAL
Description:
Add back assertion SetResourceConstraints.
This reverts commit f7f04272208d565020b528145ce6cef0f89c7079.
BUG=312233
Please review this at https://codereview.chromium.org/59133003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -2 lines):
M src/api.cc
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
8a73877eedec4b395078d7c7f2f84b103c5df763..0bb374f2dc69bea8e712d4962363e835bfbb80bc
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -574,8 +574,7 @@ bool SetResourceConstraints(ResourceConstraints*
constraints) {
int max_executable_size = constraints->max_executable_size();
if (young_space_size != 0 || old_gen_size != 0 || max_executable_size !=
0) {
// After initialization it's too late to change Heap constraints.
- // TODO(rmcilroy): fix this assert.
- // ASSERT(!isolate->IsInitialized());
+ ASSERT(!isolate->IsInitialized());
bool result = isolate->heap()->ConfigureHeap(young_space_size / 2,
old_gen_size,
max_executable_size);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
