Reviewers: danno, Benedikt Meurer, Paul Lind, kisg, palfia, Jakob,
Description:
MIPS: Use loop to initialize locals when optimizing for size.
Port r17465 (9f3f3d1)
BUG=
Please review this at https://codereview.chromium.org/59853002/
SVN Base: https://github.com/v8/v8.git@gbl
Affected files (+14, -2 lines):
M src/mips/full-codegen-mips.cc
Index: src/mips/full-codegen-mips.cc
diff --git a/src/mips/full-codegen-mips.cc b/src/mips/full-codegen-mips.cc
index
13b236945fc65c314123dbac1bdc360cafe40cc8..1f3a8169707a858cf30e335008f02a267e1411ab
100644
--- a/src/mips/full-codegen-mips.cc
+++ b/src/mips/full-codegen-mips.cc
@@ -180,8 +180,20 @@ void FullCodeGenerator::Generate() {
ASSERT(!info->function()->is_generator() || locals_count == 0);
if (locals_count > 0) {
__ LoadRoot(at, Heap::kUndefinedValueRootIndex);
- for (int i = 0; i < locals_count; i++) {
- __ push(at);
+ // Emit a loop to initialize stack cells for locals when optimizing
for
+ // size. Otherwise, unroll the loop for maximum performance.
+ __ LoadRoot(t5, Heap::kUndefinedValueRootIndex);
+ if (FLAG_optimize_for_size && locals_count > 4) {
+ Label loop;
+ __ li(a2, Operand(locals_count));
+ __ bind(&loop);
+ __ Subu(a2, a2, 1);
+ __ push(t5);
+ __ Branch(&loop, gt, a2, Operand(zero_reg));
+ } else {
+ for (int i = 0; i < locals_count; i++) {
+ __ push(t5);
+ }
}
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
