I don't like special-case solutions for individual HInstructions. The
high-level
aim here seems reasonable, but the implementation should be hooked up with
the
KnownSuccessorBlock infrastructure that we already have. That will also
avoid
the need for changes to the Lithium layer.
One challenge is that marking unreachable blocks happens long before
representations are inferred, so a reachability decision that depends on
representations will not be able to take part in that, and you'll have to
make
sure the implementation accounts for this (shouldn't be too hard).
https://codereview.chromium.org/58923004/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/58923004/diff/1/src/hydrogen-instructions.cc#newcode1321
src/hydrogen-instructions.cc:1321: AllowHandleDereference allow_deref;
No way!
If you absolutely need this information during optimization phases, set
a bit at HInstruction construction time.
https://codereview.chromium.org/58923004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
