ia32 comments also apply to x64.
https://codereview.chromium.org/58923004/diff/60001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/58923004/diff/60001/src/hydrogen-instructions.h#newcode4439
src/hydrogen-instructions.h:4439: static HTypeofIsAndBranch* New(Zone*
zone, HValue* context,
Please leave the DECLARE_INSTRUCTION_FACTORY_P2 macro alone and add this
logic to the constructor. You can get the heap via
type_literal->GetHeap().
https://codereview.chromium.org/58923004/diff/60001/src/hydrogen-instructions.h#newcode4442
src/hydrogen-instructions.h:4442: bool is_number = false;
bool is_number = type_literal->Equals(heap->number_string());
https://codereview.chromium.org/58923004/diff/60001/src/hydrogen-instructions.h#newcode4450
src/hydrogen-instructions.h:4450: bool CheckNumberString() { return
is_number_; }
I'd call the field compares_number_type_ and the accessor
compares_number_type().
https://codereview.chromium.org/58923004/diff/60001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/58923004/diff/60001/src/ia32/lithium-codegen-ia32.cc#newcode6071
src/ia32/lithium-codegen-ia32.cc:6071: Representation rep =
instr->hydrogen()->value()->representation();
Thanks to overriding KnownSuccessorBlock and the magic of
LChunkBuilder::CheckElideControlInstruction, you don't need this logic
any more.
https://codereview.chromium.org/58923004/diff/60001/src/ia32/lithium-codegen-ia32.cc#newcode6097
src/ia32/lithium-codegen-ia32.cc:6097: Label::Distance true_distance =
Label::kFar;
Label::Distance true_distance = left_block == next_block ?
Label::kNear
:
Label::kFar;
https://codereview.chromium.org/58923004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
