LGTM with comments.
https://codereview.chromium.org/59823002/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/59823002/diff/1/src/code-stubs-hydrogen.cc#newcode1201
src/code-stubs-hydrogen.cc:1201: int32_t opt_count_mask =
BitField has a kMask which you can use. Note that you'll want the
DisabledOptimizationReasonBits::kMask, though, so that opt_count is
zeroed out.
https://codereview.chromium.org/59823002/diff/1/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):
https://codereview.chromium.org/59823002/diff/1/src/runtime-profiler.cc#newcode309
src/runtime-profiler.cc:309: if (shared->opt_count() >=
FLAG_max_opt_count) {
This changes behavior, and could easily have unintended side effects. As
discussed, I'd prefer to make this change in a separate CL and carefully
watch the performance impact.
https://codereview.chromium.org/59823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
