Reviewers: Michael Starzinger,
Message:
\o/
Description:
Remove SetLocalPropertiesIgnoreAttributesTrampoline
BUG=v8:2877
Please review this at https://codereview.chromium.org/59343003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -32 lines):
M src/objects.h
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
8bb603a985db87e6a8c0d78be94d081b74777f67..5ea9b5a4e490a3faae793e3da5a18e0d4d37463e
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4122,29 +4122,6 @@ Handle<Object>
JSObject::SetPropertyForResult(Handle<JSObject> object,
}
-MaybeObject* JSObject::SetLocalPropertyIgnoreAttributesTrampoline(
- Name* key,
- Object* value,
- PropertyAttributes attributes,
- ValueType value_type,
- StoreMode mode,
- ExtensibilityCheck extensibility_check) {
- // TODO(mstarzinger): The trampoline is a giant hack, don't use it
anywhere
- // else or handlification people will start hating you for all eternity.
- HandleScope scope(GetIsolate());
- IdempotentPointerToHandleCodeTrampoline trampoline(GetIsolate());
- return trampoline.CallWithReturnValue(
- &JSObject::SetLocalPropertyIgnoreAttributes,
- Handle<JSObject>(this),
- Handle<Name>(key),
- Handle<Object>(value, GetIsolate()),
- attributes,
- value_type,
- mode,
- extensibility_check);
-}
-
-
// Set a real local property, even if it is READ_ONLY. If the property is
not
// present, add it with attributes NONE. This code is an exact clone of
// SetProperty, with the check for IsReadOnly and the check for a
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
e7586f5db63e11d8fb18064c7fed75b91eb5174f..99c160b51d5c79e93fa2675745387428fa207c31
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -2193,15 +2193,6 @@ class JSObject: public JSReceiver {
// or returns an empty handle if such a map is not yet available.
static Handle<Object> TryMigrateInstance(Handle<JSObject> instance);
- // Can cause GC.
- MUST_USE_RESULT MaybeObject* SetLocalPropertyIgnoreAttributesTrampoline(
- Name* key,
- Object* value,
- PropertyAttributes attributes,
- ValueType value_type = OPTIMAL_REPRESENTATION,
- StoreMode mode = ALLOW_AS_CONSTANT,
- ExtensibilityCheck extensibility_check =
PERFORM_EXTENSIBILITY_CHECK);
-
// Retrieve a value in a normalized object given a lookup result.
// Handles the special representation of JS global objects.
Object* GetNormalizedProperty(LookupResult* result);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
