DBC.
https://codereview.chromium.org/61623004/diff/30001/src/property-details.h
File src/property-details.h (right):
https://codereview.chromium.org/61623004/diff/30001/src/property-details.h#newcode137
src/property-details.h:137: return kind_ > other.kind_;
This simplification is not correct for e.g. kInteger8 vs. kUInteger8. At
least please add ASSERTs to ensure this function isn't called for
representations it can't handle.
https://codereview.chromium.org/61623004/diff/30001/test/cctest/test-macro-assembler-ia32.cc
File test/cctest/test-macro-assembler-ia32.cc (right):
https://codereview.chromium.org/61623004/diff/30001/test/cctest/test-macro-assembler-ia32.cc#newcode1
test/cctest/test-macro-assembler-ia32.cc:1: // Copyright 2009 the V8
project authors. All rights reserved.
nit: 2013
https://codereview.chromium.org/61623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
