On 2013/11/08 10:49:11, danno wrote:
https://codereview.chromium.org/61623004/diff/210001/src/hydrogen-load-elimination.cc
File src/hydrogen-load-elimination.cc (right):
https://codereview.chromium.org/61623004/diff/210001/src/hydrogen-load-elimination.cc#newcode277
src/hydrogen-load-elimination.cc:277:
access.representation().IsUInteger8())
size = 1;
On 2013/11/08 08:45:59, Yang wrote:
> I favor adding brackets for readability.
Done.
https://codereview.chromium.org/61623004/diff/210001/src/hydrogen-load-elimination.cc#newcode277
src/hydrogen-load-elimination.cc:277:
access.representation().IsUInteger8())
size = 1;
On 2013/11/08 09:09:30, Sven Panne wrote:
> On 2013/11/08 08:45:59, Yang wrote:
> > I favor adding brackets for readability.
>
> I would favor something actually OO-like: Adding a method to
Representation.
> This is plain old imperative C code here...
Done.
https://codereview.chromium.org/61623004/diff/210001/src/v8globals.h
File src/v8globals.h (right):
https://codereview.chromium.org/61623004/diff/210001/src/v8globals.h#newcode586
src/v8globals.h:586:
On 2013/11/08 08:45:59, Yang wrote:
> I actually had globals.h in mind, not v8globals. We already got kMaxInt
etc.
> there.
Done.
lgtm.
https://codereview.chromium.org/61623004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
