On 2013/11/06 23:54:26, palfia wrote:
Hi Yang and Jakob,

Please take a look.

Thanks!

Seems like the right place to compare stack_size_ to PTHREAD_STACK_MIN is at the
place where stack_size_ is initialized as part of Thread constructor.

I would even go even further and just do a CHECK_GE(stack_size_,
PTHREAD_STACK_MIN) so people setting arbitrarily small stack limits are not
surprised it's ignored.

https://codereview.chromium.org/63183003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to