On 2013/11/08 17:34:36, palfia wrote:
On 2013/11/08 08:55:14, Yang wrote:
> On 2013/11/07 15:18:29, palfia wrote:
> > Thanks for the review! I've uploaded a new patchset, my answers are
below.
> >
> > On 2013/11/07 09:40:08, Yang wrote:
> > > On 2013/11/06 23:54:26, palfia wrote:
> > > > Hi Yang and Jakob,
> > > >
> > > > Please take a look.
> > > >
> > > > Thanks!
> > >
> > > Seems like the right place to compare stack_size_ to
PTHREAD_STACK_MIN
is
at
> > the
> > > place where stack_size_ is initialized as part of Thread
constructor.
> >
> > Done.
> >
> > > I would even go even further and just do a CHECK_GE(stack_size_,
> > > PTHREAD_STACK_MIN) so people setting arbitrarily small stack limits
are
not
> > > surprised it's ignored.
> >
> > The main problem is that the small stack size value is actually coming
from
> > kSweeperThreadStackSize, kSamplerThreadStackSize and
kProfilerStackSize
> > constants, which are all smaller than the minimal stack size on MIPS
(128KB).
> So
> > this CHECK would be always false on MIPS.
>
> lgtm.
It seems that patchset #2 introduces some test failures on ia32/x64. The
stack_size_ = 0 case means that the thread must use the default stack
size,
but
this solution replaces the 0 value with PTHREAD_STACK_MIN.
I've uploaded a new patchset which solves these failures.
Please take another look.
lgtm
https://codereview.chromium.org/63183003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
