Revision: 17725
Author: [email protected]
Date: Thu Nov 14 10:11:06 2013 UTC
Log: Magic fix for Math.sin/cos.
It turns out that Sunspider 1.0's 3d-morph verifies that the floating
point error must start with 6.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/61593008
http://code.google.com/p/v8/source/detail?r=17725
Modified:
/branches/bleeding_edge/src/math.js
=======================================
--- /branches/bleeding_edge/src/math.js Wed Nov 13 16:10:03 2013 UTC
+++ /branches/bleeding_edge/src/math.js Thu Nov 14 10:11:06 2013 UTC
@@ -217,7 +217,9 @@
// Also define the initialization function that populates the lookup table
// and then wires up the function definitions.
function SetupTrigonometricFunctions() {
- var samples = 1800; // Table size.
+ // TODO(yangguo): The following table size has been chosen to satisfy
+ // Sunspider's brittle result verification. Reconsider relevance.
+ var samples = 4489;
var pi = 3.1415926535897932;
var pi_half = pi / 2;
var inverse_pi_half = 2 / pi;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
