LGTM. One optional suggestion.
https://codereview.chromium.org/73893005/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/73893005/diff/1/test/cctest/test-heap-profiler.cc#newcode2242
test/cctest/test-heap-profiler.cc:2242: " try {\n"
I guess the try-catch is used to prevent optimization. We could also use
%NeverOptimizeFunction() instead. I don't mind either way, I'll leave
the decision up to you.
https://codereview.chromium.org/73893005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
