https://codereview.chromium.org/73893005/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/73893005/diff/1/test/cctest/test-heap-profiler.cc#newcode2235
test/cctest/test-heap-profiler.cc:2235: static const char*
inline_heap_allocation_source =
On 2013/11/15 13:44:15, loislo wrote:
I see no reason to think that it was an inline allocation except the
knowledge
about v8 internals.
So lets rename the test or add the check that it was the inline
allocation.

Done. Added additional step which checks that the number of allocations
is incorrect if inline allocations are manually enabled. PTAL.

https://codereview.chromium.org/73893005/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to