Updated patch with a "better" implementation of HAdd::New. I still have
reservations.
https://codereview.chromium.org/59023003/diff/260001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/59023003/diff/260001/src/hydrogen-instructions.cc#newcode3788
src/hydrogen-instructions.cc:3788: if (!forced_representation.IsNone())
{
I am not entirely convinced this is a good change. In my original patch,
I explicitly created an (external + offset) => external instruction,
which is the only case we handle downstream. Here it appears that we can
handle a (r + smth) => r for all r, which is not true. wdyt?
https://codereview.chromium.org/59023003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
