Getting very close...
https://codereview.chromium.org/59023003/diff/510001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/59023003/diff/510001/src/hydrogen.cc#newcode8176
src/hydrogen.cc:8176:
HObjectAccess::ForJSObjectOffset(JSTypedArray::kLengthOffset),
Here an elsewhere, does it perhaps make sense to wrap these
HObjectAccess builders in utility functions? That's what we've done
elsewhere, it provides another level of indirection, e.g.:
HObjectAccess::ForJSTypedArrayLength()
https://codereview.chromium.org/59023003/diff/510001/src/hydrogen.cc#newcode8180
src/hydrogen.cc:8180: Add<HAllocate>(
nit: 4 char indent
https://codereview.chromium.org/59023003/diff/510001/src/hydrogen.cc#newcode8188
src/hydrogen.cc:8188:
nit: Group the load/store pairs and their preparation that belong
together, e.g. remove this line
https://codereview.chromium.org/59023003/diff/510001/src/hydrogen.cc#newcode8191
src/hydrogen.cc:8191: Add<HConstant>(external_array_map));
nit: And insert one after this line
https://codereview.chromium.org/59023003/diff/510001/src/hydrogen.cc#newcode8195
src/hydrogen.cc:8195:
nit: remove this line
https://codereview.chromium.org/59023003/diff/510001/src/hydrogen.cc#newcode8215
src/hydrogen.cc:8215:
HObjectAccess::ForJSObjectOffset(ExternalArray::kLengthOffset),
I think it's safe to use HObjectAccoess::ForFixedArrayLength() here,
since ExternalArray derives from FixedArrayBase, and ForFixedArrayLength
is valid for all subclasses of it.
https://codereview.chromium.org/59023003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
