LGTM with a comment.
https://codereview.chromium.org/66703005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/66703005/diff/1/src/runtime.cc#newcode6892
src/runtime.cc:6892: uint8_t* bytes =
reinterpret_cast<uint8_t*>(&result);
Are you sure this compiles? AFAIK this is what we have BitCast for.
(You'll probably want to start with an uint8_t[8] and then BitCast to
double.)
https://codereview.chromium.org/66703005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
