On 2013/11/20 09:05:46, Yang wrote:
On 2013/11/20 07:38:34, Sven Panne wrote: > DBC > > https://codereview.chromium.org/66703005/diff/1/src/math.js > File src/math.js (right): > > https://codereview.chromium.org/66703005/diff/1/src/math.js#newcode222 > src/math.js:222: var inverse_pi_half =
%HeapNumberFromHex("83c8c96d305fe43f");
> Why do we need a new %Foo? Our scanner should be able to produce the bit pattern > you want directly from a floating point literal. If not, fix the scanner instead > of introducing a new %Foo. > > https://codereview.chromium.org/66703005/diff/1/test/mjsunit/sin-cos.js > File test/mjsunit/sin-cos.js (right): > >
https://codereview.chromium.org/66703005/diff/1/test/mjsunit/sin-cos.js#newcode148
> test/mjsunit/sin-cos.js:148: function assertError(expected, x, epsilon) {> Can we move this to mjsunit.js under a better name, e.g. > assertEqualsDelta(expected, actual, delta, opt_message)? Or just
assertEquals
> and dispatch on the third argument (message or delta). See >
http://junit.sourceforge.net/javadoc/org/junit/Assert.html#assertEquals%2528double,
> double, double)
addressed comments.
Added some further improvements. https://codereview.chromium.org/66703005/ -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
