https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h
File src/spaces-inl.h (right):
https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h#newcode339
src/spaces-inl.h:339: Address new_top = allocation_info_.top() +
filler_size;
On 2013/10/25 08:34:56, Michael Starzinger wrote:
nit: Only one white-space after assignment operator.
Done.
https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h#newcode340
src/spaces-inl.h:340: allocation_info_.set_top(new_top);
On 2013/10/25 08:34:56, Michael Starzinger wrote:
nit: Maybe inline calculation instead of local variable.
Done.
https://codereview.chromium.org/40083002/diff/1/src/spaces-inl.h#newcode351
src/spaces-inl.h:351: allocation_info_.set_top(new_top);
On 2013/10/25 08:34:56, Michael Starzinger wrote:
nit: Maybe inline calculation instead of local variable.
Done.
https://codereview.chromium.org/40083002/diff/1/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/40083002/diff/1/src/spaces.h#newcode1324
src/spaces.h:1324: ASSERT(top == NULL ||
On 2013/10/25 08:34:56, Michael Starzinger wrote:
nit: As discussed offline, maybe consider making all of these
SLOW_ASSERTs
instead.
Done.
https://codereview.chromium.org/40083002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
