LGTM with nits
https://codereview.chromium.org/77913003/diff/1/src/isolate.cc
File src/isolate.cc (right):
https://codereview.chromium.org/77913003/diff/1/src/isolate.cc#newcode1723
src/isolate.cc:1723: embedder_data_(),
Can't we simply remove this line?
https://codereview.chromium.org/77913003/diff/1/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/77913003/diff/1/src/isolate.h#newcode1053
src/isolate.h:1053: void SetData(uint32_t slot, void* data) {
embedder_data_[slot] = data; }
An ASSERT that slot is in range might be nice here and below.
https://codereview.chromium.org/77913003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
