https://codereview.chromium.org/61463005/diff/360001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/61463005/diff/360001/src/hydrogen-instructions.cc#newcode3464
src/hydrogen-instructions.cc:3464: if
(current_size->IsInteger32Constant()) {
The size check code with tracing output is almost the same, can we
refactor that?
https://codereview.chromium.org/61463005/diff/360001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/61463005/diff/360001/src/hydrogen.h#newcode1674
src/hydrogen.h:1674: // array must have been allocated with enough room
for
Can you change "array" to "Array".
https://codereview.chromium.org/61463005/diff/360001/src/hydrogen.h#newcode1675
src/hydrogen.h:1675: // 1) the JSArray, 2) a AllocationMemento if mode
requires it.
-instead of "," -> "and"
-an AllocationMemento
https://codereview.chromium.org/61463005/diff/360001/src/objects-printer.cc
File src/objects-printer.cc (right):
https://codereview.chromium.org/61463005/diff/360001/src/objects-printer.cc#newcode952
src/objects-printer.cc:952:
CodeStub::MajorName(CodeStub::GetMajorKey(this), true));
Why is this change in here?
https://codereview.chromium.org/61463005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
