https://chromiumcodereview.appspot.com/40063002/diff/550001/src/allocation-site-scopes.cc
File src/allocation-site-scopes.cc (right):
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/allocation-site-scopes.cc#newcode100
src/allocation-site-scopes.cc:100:
ASSERT(FLAG_allocation_site_pretenuring);
This assert has to hold in that case, please remove it.
I think it would make sense to assert that the type of the object is
JSObject or JSArray.
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/allocation-site-scopes.cc#newcode102
src/allocation-site-scopes.cc:102: PrintF("*** Creating Memento for
JSObject/JSArray %p\n",
Can we determine JSObject/JSArray dynamically?
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/heap.cc
File src/heap.cc (right):
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/heap.cc#newcode514
src/heap.cc:514: if (cur->IsAllocationSite()) {
I guess the if is not needed.
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/heap.cc#newcode4403
src/heap.cc:4403: reinterpret_cast<Address>(result) +
map->instance_size());
Is there a way to increase the memento count at memento creation time?
Right now it seems to be a bit fragile to manually increase the counter
after creating the memento.
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/hydrogen.cc#newcode2249
src/hydrogen.cc:2249: BuildCreateAllocationMemento(array,
I guess it would make sense to make the code block below part of
BuildCreateAllocationMemento. WDYT?
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/hydrogen.cc#newcode2264
src/hydrogen.cc:2264: // no write barrier needed to store a smi.
"No"
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/mark-compact.h
File src/mark-compact.h (right):
https://chromiumcodereview.appspot.com/40063002/diff/550001/src/mark-compact.h#newcode742
src/mark-compact.h:742: // Special case for processing weak references
in a compacting collection.
"compacting" -> "full"
https://chromiumcodereview.appspot.com/40063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
