LGTM, just minor nits. The next step should be a set of tests. BTW. can you
rename this CL to "Bookkeeping for allocation site pretenuring"
https://codereview.chromium.org/40063002/diff/660001/src/allocation-site-scopes.cc
File src/allocation-site-scopes.cc (right):
https://codereview.chromium.org/40063002/diff/660001/src/allocation-site-scopes.cc#newcode89
src/allocation-site-scopes.cc:89: if (FLAG_allocation_site_pretenuring)
{
This method looks too complicated.
What about:
if (activated_ &&
AllocationSite::CanTrack(object->map()->instance_type())) {
if (FLAG_allocation_site_pretenuring ||
AllocationSite::GetMode(object->GetElementsKind()) ==
TRACK_ALLOCATION_SITE) {
if (FLAG_trace_creation_allocation_sites) {
PrintF("*** Creating Memento for %s %p\n",
object->IsJSArray() ? "JSArray" : "JSObject",
static_cast<void*>(*object));
}
return true;
}
}
return false;
https://codereview.chromium.org/40063002/diff/660001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/40063002/diff/660001/src/objects.cc#newcode9213
src/objects.cc:9213: // Currently, AllocationMemento objects are only
allocated immediately
Please update this comment.
https://codereview.chromium.org/40063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
