I commented arm sources but the same notes are related to other platforms'
sources.
lgtm with notes.
https://codereview.chromium.org/83753002/diff/70001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (left):
https://codereview.chromium.org/83753002/diff/70001/src/arm/stub-cache-arm.cc#oldcode766
src/arm/stub-cache-arm.cc:766:
Non-equivalent modification for one of the GenerateCallFunction()
usages. See below.
https://codereview.chromium.org/83753002/diff/70001/src/arm/stub-cache-arm.cc#oldcode1617
src/arm/stub-cache-arm.cc:1617: // -----------------------------------
Are these (and similar) comments really useless here?
https://codereview.chromium.org/83753002/diff/70001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/83753002/diff/70001/src/arm/stub-cache-arm.cc#newcode1613
src/arm/stub-cache-arm.cc:1613: HandlerFrontendHeader(object, holder,
name, RECEIVER_MAP_CHECK, &miss);
Eagle's eye!
https://codereview.chromium.org/83753002/diff/70001/src/arm/stub-cache-arm.cc#newcode2380
src/arm/stub-cache-arm.cc:2380: // -----------------------------------
What do you think about putting these comments here:
// -- sp[(argc - n - 1) * 4] : arg[n] (zero-based)
// -- ...
// -- sp[argc * 4] : receiver
// -----------------------------------
https://codereview.chromium.org/83753002/diff/70001/src/arm/stub-cache-arm.cc#newcode2383
src/arm/stub-cache-arm.cc:2383: Register reg = r1;
It looks like the other usages of "r1" below should be replaced with
"reg".
https://codereview.chromium.org/83753002/diff/70001/src/arm/stub-cache-arm.cc#newcode2524
src/arm/stub-cache-arm.cc:2524: GenerateCallFunction(masm(), object,
arguments(), &miss, extra_state_);
Modified GenerateCallFunction() is no longer patches the receiver on the
stack. Is it true that we no longer need this check here?
https://codereview.chromium.org/83753002/diff/70001/src/stub-cache.h
File src/stub-cache.h (right):
https://codereview.chromium.org/83753002/diff/70001/src/stub-cache.h#newcode909
src/stub-cache.h:909: Register HandlerFrontendHeader(Handle<Object>
object,
Probably is it worth adding a comment about what is returned from the
function.
https://codereview.chromium.org/83753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
