lgtm with nits which as I saw you already address in the next CL.
https://codereview.chromium.org/83753002/diff/110001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/83753002/diff/110001/src/arm/stub-cache-arm.cc#newcode760
src/arm/stub-cache-arm.cc:760: if (object->IsGlobalObject()) {
Looks like PatchGlobalProxy(object);
Why don't make GenerateCallFunction() private method and call the patch
function?
https://codereview.chromium.org/83753002/diff/110001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://codereview.chromium.org/83753002/diff/110001/src/ia32/stub-cache-ia32.cc#newcode2656
src/ia32/stub-cache-ia32.cc:2656: if (object->IsGlobalObject()) {
Looks like PatchGlobalProxy(object);
https://codereview.chromium.org/83753002/diff/110001/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/83753002/diff/110001/src/x64/stub-cache-x64.cc#newcode2577
src/x64/stub-cache-x64.cc:2577: if (object->IsGlobalObject()) {
Looks like PatchGlobalProxy(object);
https://codereview.chromium.org/83753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
